Minor refactoring of GameUnit #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and some other refactors.
…gine-Source into sep_unit_refactoring
royfalk
requested review from
BenjamenMeyer,
evertvorster,
ministerofinformation and
stephengtuggy
|
@stephengtuggy can you comment on the build break? I don't see anything in the logs. I also don't see issues with order of class field. |
|
@royfalk Windows CI is failing for us across the board right now. That started about 3 or 4 days ago. I've been troubleshooting, and working with the vcpkg team, but no resolution yet. Since it's only that one platform that failed here, I would honestly just ignore it and move forward. |
BenjamenMeyer
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves and refactors some unit.cpp code to Drawable class and some other places. It is for any coming release and no specific milestone.
Code Changes:
Issues: