Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build issues with Boost 1.78 on windows by reverting to Boost 1.77 (alternate approach) #650

Merged
merged 2 commits into from Feb 19, 2022
Merged

Fix build issues with Boost 1.78 on windows by reverting to Boost 1.77 (alternate approach) #650

merged 2 commits into from Feb 19, 2022

Conversation

stephengtuggy
Copy link
Contributor

@stephengtuggy stephengtuggy commented Feb 17, 2022 •
edited

Thank you for submitting a pull request and becoming a contributor to the Vega Strike Core Engine.

Please answer the following:

Code Changes:

Issues:

  • Please list any related issues

Purpose:

  • What is this pull request trying to do? Fix the build on Windows by reverting Boost to version 1.77 instead of 1.78
  • What release is this for? 0.9.x
  • Is there a project or milestone we should apply this to? 0.9.x

@stephengtuggy stephengtuggy added bug CI/CD Compiler Error Breaks build on at least one supported platform labels Feb 17, 2022
@stephengtuggy stephengtuggy added this to the 0.9.x milestone Feb 17, 2022
@stephengtuggy stephengtuggy self-assigned this Feb 17, 2022
@stephengtuggy stephengtuggy added this to In progress in 0.9.x Release Feb 18, 2022
@stephengtuggy stephengtuggy marked this pull request as ready for review February 18, 2022 02:23
@stephengtuggy stephengtuggy requested a review from a team February 18, 2022 02:23
@stephengtuggy
Copy link
Contributor Author

Note: The only part of the CI that failed was the CodeQL scanning results. And I'm pretty sure I didn't introduce any of those "new high severity vulnerabilities" in this PR.

Loki1950
Loki1950 approved these changes Feb 19, 2022
View reviewed changes
Copy link
Member

@Loki1950 Loki1950 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now to figure out where the multiplication type change came from

@stephengtuggy stephengtuggy merged commit c000f69 into vegastrike:master Feb 19, 2022
@stephengtuggy stephengtuggy mentioned this pull request Feb 19, 2022
Closed
2 tasks
@stephengtuggy stephengtuggy moved this from In progress to Done in 0.9.x Release Mar 26, 2022
@stephengtuggy stephengtuggy deleted the fix/boost-1.78-issues-on-windows branch March 26, 2022 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Loki1950 Loki1950 Loki1950 approved these changes

@BenjamenMeyer BenjamenMeyer Awaiting requested review from BenjamenMeyer

Assignees

@stephengtuggy stephengtuggy

Labels
bug CI/CD Compiler Error Breaks build on at least one supported platform
Projects
No open projects
0.9.x Release
Done
Milestone
0.9.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stephengtuggy @Loki1950