For 0.9.x - MacPorts support, plus destructor crash fixes; lin_time and vs_config refactors; and more #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wner.h, vega_collection_utils.cpp, and vega_collection_utils.h. In CMakeLists.txt, change C++ standard to C++14. (Hurray!)
…ly on macOS! Yay! Also, replaced the functionality of the winsys_enable_key_repeat function, which used SDL constructs that are deprecated in SDL2. Finally, moved the definition of remove_all_references_to into the header file (vega_collection_utils.h), rendering vega_collection_utils.cpp obsolete.
…rying to get something to show up besides a blank window. Also, added functionality to quit the game when the SDL_QUIT event is triggered, i.e. (on macOS) by trying to close the window, or by choosing Quit from the Application menu.
stephengtuggy
changed the title
…ncorporate changes from PR vegastrike#821 ; fix macOS detection ("Darwin")
1 task
This was
linked to
issues
Apr 29, 2024
This was referenced Apr 29, 2024
…ries -- to bin folder
…vs_logging.cpp: Don't log after STATIC_VARS_DESTROYED.
…, at least on macOS, at least for now
…, if necessary. I'm spending too much time trying to figure out the Windows-specific logic.
stephengtuggy
changed the title
stephengtuggy
commented
May 1, 2024
…ib-2.0, and thus allowing vegasettings to work on macOS!
|
Okay, there is one bug that I have been running into with this code. When I load a saved game from the Main Menu, and then jump through a warp point, the game crashes within a minute or so after the jump. The crash occurs in We will need to take a look at this, but hopefully it can wait until another PR to be fixed. |
Closed
Closed
…lic links to GL/ to be added by the bootstrap scripts. Also add 4 more configures preset to CMakePresets.json (MacPorts versions of the existing macOS presets).
…ce that is what I have on my machine
BenjamenMeyer
approved these changes
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Changes:
Closes #533
Known Issues:
Update 2: graphics now showing up on all three platforms -- macOS, Windows, and Linux -- and performance is much better than it was a day or so ago. Loading assets on startup may take somewhat longer now, but other than that, I am not aware of any new issues with this code.
Purpose: