Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow other tags inside url #34

Closed
wants to merge 1 commit into from
Closed

Allow other tags inside url #34

wants to merge 1 commit into from

Conversation

almaron
Copy link

@almaron almaron commented May 25, 2019

#32 Fix

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.3%) to 98.373% when pulling 5de6e85 on almaron:fix-url-tag into 0b9ea50 on veger:master.

@veger
Copy link
Owner

veger commented May 27, 2019

This PR breaks the support of [url]https://www.google.com[/url] and only allows this syntax: [url=https://www.google.com]Google[/url]

Shown by this failing test: https://travis-ci.org/veger/ruby-bbcode/jobs/537100986#L599

@veger
Copy link
Owner

veger commented May 27, 2019

Implemented by 1110457

@veger veger closed this May 27, 2019
@almaron almaron deleted the fix-url-tag branch May 29, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@almaron @coveralls @veger