Can't disable labels in Magento #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e boolean or string here
…e boolean or string here
|
Please make unit tests for the condition that you just fixed. |
…which didn't work if the select element wasn't a direct child of the form. This now looks at all parent elements and takes the first occurence (closest parent).
|
Hi Kyle. I've had a quick look, and I'll need to investigate more on how to change the configuration settings as part of the test, so I'll get round to this when I have some free time. Cheers. |
|
I'll see if I can help write a test when I get chance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the first pull request - I hadn't synced my client's code with the forked repo. oops
Vehcle-Fits-Mangento stores the labels attribute as a string, which always evaluates as true when cast to a boolean. I've updated the core to accept either (bool) true, or 'true' (case insensitively).
Please consider pulling in :)