-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【確認待ち】Outerブロックカラーパレット対応 #1032
Closed
mthaichi
wants to merge
39
commits into
develop
from
fix/outer/custom-color-pallete-bgcontainer-style
Closed
【確認待ち】Outerブロックカラーパレット対応 #1032
mthaichi
wants to merge
39
commits into
develop
from
fix/outer/custom-color-pallete-bgcontainer-style
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # inc/vk-blocks/languages/vk-blocks-js.pot # inc/vk-blocks/languages/vk-blocks.pot
# Conflicts: # inc/vk-blocks/languages/vk-blocks.pot
…r/custom-color-palette # Conflicts: # inc/vk-blocks/languages/vk-blocks-js.pot # src/blocks/_pro/outer/index.php
fix: ブレイクポイン値の変更
This reverts commit 716e50d.
mthaichi
requested review from
kurudrive,
sysbird,
goutetsuguma,
drill-lancer,
shimotmk,
ChiakiKouno and
kaorock72
February 24, 2022 10:04
7 tasks
mthaichi
assigned kurudrive, sysbird, goutetsuguma, drill-lancer, shimotmk, ChiakiKouno and kaorock72
Feb 24, 2022
@shimotmk これは前にお話した下記のようCurrentColorを使った場合、CSS自体の枠線スタイルがgrooveやridgeのときだけ適用されないことの対応でした。JSはブロックの動作を大きく左右するものではないですが、has-border系のクラスができたんでしたっけ。それで対応できれば、そちらがいいですね。 どうぞいったん引き取ってくださいー。
|
shimotmk
deleted the
fix/outer/custom-color-pallete-bgcontainer-style
branch
February 25, 2022 02:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
大幅な構造変更をかけましたので、入念なるチェックをお願いできればと思います。
開発メンバー以外の方でも確認できる環境をお持ちであれば、動作チェックしていただけると嬉しいです。(ご無理なく)
特に以下の点についてご確認ください。
以前からブランチを変更しております。