Break up script tags to allow inline use

[doryphores]

Breaking up the closing <script> tag allows jasmine-query.js to be included inline in a script tag: A closing script tag would cause the browser to believe the script has come to an end.

I have a situation where I couldn't load it externally and it broke my test suite.

[travisjeffery]

wat?

[doryphores]

I know, it's an odd request. I have a project where I have to render jasmine-query inside a script tag instead of referencing it the normal way. So:

<script>
// jasmine-query goes here along with other scripts
</script>

instead of:

<script src="jasmine-query.js"></script>

If the contents of a script tag include an unescaped closing script tag, it causes the tag to close early. See this stackoverflow answer.

It's a tiny issue but I had to change the file to use it so this may help someone in the future.

[travisjeffery]

i don't get how this is fixing it though, it ends up being the same string

[doryphores]

Here's why: http://stackoverflow.com/questions/236073/why-split-the-script-tag-when-writing-it-with-document-write

In my opinion, it's a tiny change that fixes a rare issue and has no side effects. Why reject it?