This repository has been archived by the owner on Jul 26, 2023. It is now read-only.
Explicitly use GET for loading fixtures #276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows jasmine-jquery to use fixtures even when testing code that overrides the default request method for jQuery.
|
No activity for years, closing. Our solution was to stop overriding the default request method, and explicitly add type: 'POST' to every jquery call that didn't have it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
method: 'GET'to every$.ajaxcall - this allows jasmine-jquery to use fixtures even when testing code that overrides the default request method for jQuery.(That can be done via
$.ajaxSetup({ type: "POST" });.)What do you think?
If we want to support jquery < 1.9, I can change
methodtotype..Not sure how to test this..?