This repository has been archived by the owner on Jul 26, 2023. It is now read-only.
Added check of exports to allow successful execution in Electron #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed spacing to match code standards
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into this issue in Jasmine. Jasmine has merged it but hasn't release it yet. So, I fixed it in my local copy and proceeded to add Jasmine-jQuery.
Lo and behold, Jasmine-jQuery had the same issue. In fact, it looked like the offending code had been cut from Jasmine and pasted into Jasmine-jQuery. Nothing wrong with that, of course. So, I made the same change to my local and it worked. So, I'm sharing the love and passing it on.
I didn't write any additional tests because, frankly, I don't see an easy way that I could. It appears that the user who added the code I am modifying also didn't write any so this probably isn't a big deal. I did, however, actually run them. So, at least there's that.
I also cleaned up the function from a spacing point of view. The rest of the codebase and the contributing guidelines say '2 spaces'. This bit had four and to first line actually had a stray extra space. Five, as they say, is right out.