Feature/expire

[hakod]

Hi @dr-dimitru,

I added an expiration feature for while code is still active. Wasn't sure whether to add timestamp for expiration date since the other PR already had that. Please let me know if I should change it to use a timestamp as well. Thanks again.

[dr-dimitru]

@hakod thank you for the quick PR.

1. How is it going to work after page reload?
2. Yes, don't mind another PRs
3. Please let's discuss an idea before implementing it

[hakod]

@dr-dimitru No problem! Yeah, I was concerned that the setTimeout would be interrupted. Would a timestamp be the best route and should there be a setInterval to check for expiration every so often? Thanks for reviewing.

[dr-dimitru]

@hakod I believe we should utilize cookie's expiration in case if cookies are used, use records with .___expireAt prefix holding expirations timestamp, having loop via setInterval(()=>{}, 256) for LocalStorage, and use setTimeout for JS implementation when LocalStorage nor Cookies are available. Does it sounds clear?

[hakod]

@dr-dimitru Yes, I think I understand it.

[hakod]

@dr-dimitru Added the cookie expiration using max-age and the prefix to store expiration times. Let me know if there are any changes needed. Thanks.

[dr-dimitru]

@hakod thank you, added notes

[hakod]

@dr-dimitru Thanks for the feedback, I really appreciate it. The last note was a bit difficult for me to fix. Should setInterval be triggered whenever page loads? How could I get that working?

[dr-dimitru]

Check inside constructor if localStorage is supported and setInterval

[dr-dimitru]

Dear @hakod ,

Thank you for your PR and attempt, final solution released as v3.0.0.
Do not hesitate to share your opinion 👨‍💻

[hakod]

Hi @dr-dimitru,
It is interesting you used a while statement instead of setInterval to remove localstorage. Wondering what the reason for that change was.

[dr-dimitru]

@hakod not using while nor setInterval. Timers are unreliable in Browser's runtime environment. Timers will also pollute JS runtime. So, I'm just checking for expiration date here and remove it from storage if expired, it's also happening when ClientStorage instance is initiated

[hakod]

OK I think I understand it now. Would it delete without a page refresh too?

[dr-dimitru]

No, only upon request if expired or on page init. Very similar to how cookies and expiration works in most of browsers

[hakod]

That makes a lot more sense. Thanks.