Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added expiration to storage #4

Closed
wants to merge 1 commit into from

Conversation

JspHansen
Copy link

Thank you for contribution. Before you go:

  1. Make sure you're using spaces for indentation
  2. Make sure all new code is documented in-code-docs
  3. Make sure new features, or changes in behavior is documented in README.md and/or other docs materials
  4. Make sure this PR was previously discussed, if not create new issue ticket for your PR
  5. Give an expressive description what you have changed/added and why

Thank you for making this package better :)

Do not forget to get rid of this default message

@dr-dimitru
Copy link
Member

Hello @JspHansen ,

Thank you for sending this PR, do you wish to discuss and explain how you came up with this solution?

@dr-dimitru
Copy link
Member

@JspHansen I believe it's a waaaay over complexified and has a lot of major changes. I see the other simpler way to achieve it, want to try one more time?

dr-dimitru added a commit that referenced this pull request May 22, 2019
- 👷‍♂️ Overall codebase refactoring
- 📦 Reduced size of the package, for minimal footprint and top
performance
- 👨‍💻 Add support for TTL, closing #4 #5 and #2 , thanks to @bobagold
@hakod and @JspHansen
- 👨‍🔬 Tests for new TTL feature
- 🤝 Compatibility with `meteor@1.8.1`
@dr-dimitru
Copy link
Member

Dear @JspHansen ,

Thank you for your PR and attempt, final solution released as v3.0.0.
Do not hesitate to share your opinion 👨‍💻

@dr-dimitru dr-dimitru closed this May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants