Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect keys extracted #12

Closed
TomaszCz opened this issue Jun 30, 2023 · 2 comments · Fixed by #21
Closed

Incorrect keys extracted #12

TomaszCz opened this issue Jun 30, 2023 · 2 comments · Fixed by #21
Labels
help wanted Extra attention is needed

Comments

@TomaszCz
Copy link

Hey guys, this is great library! I appreciate you took over the maintenance.

I find some edge cases using this library and i failed to eliminate them with build in parameters. The only way to address that was to refactor my code / or filter output of the script.

It seem the code extract keys from any chained methods to .instant() usage e.g. 'replace' and 'split' contained strings.

image
image

I guess this is taking full array. https://github.com/vendure-ecommerce/ngx-translate-extract/blob/master/src/utils/ast-helpers.ts#L56

@michaelbromley michaelbromley added the help wanted Extra attention is needed label Aug 10, 2023
@michaelbromley
Copy link
Member

Hi,
Thanks for the report!

I've marked this as "help wanted" because I don't have time to address this right now. Anyone who feels like tackling this, please let me know 🙏

@bastianjoel
Copy link

Not entirely sure but I think we have a fix for that in our fork: OpenSlides@b3d35b6

michaelbromley pushed a commit that referenced this issue Sep 21, 2023
Fixes #12

---------

Co-authored-by: Joshua Sangmeister <joshua.sangmeister@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants