Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mollie plugin returns unavailable payment methods for given currency #2510

Closed
StampixSMO opened this issue Nov 7, 2023 · 0 comments · Fixed by #2516
Closed

Mollie plugin returns unavailable payment methods for given currency #2510

StampixSMO opened this issue Nov 7, 2023 · 0 comments · Fixed by #2516
Assignees
Labels
type: bug 🐛 Something isn't working

Comments

@StampixSMO
Copy link
Contributor

Describe the bug
The molliePaymentMethods query in the MolliePlugin, returns all enabled payment methods. However, it doesn't forward any currency data to Mollie, which therefore just returns all enabled payment methods. For a proper checkout flow, the plugin should leave out methods that are not supported for the current order's currency.

To Reproduce
Steps to reproduce the behavior:

  1. Add the MolliePlugin
  2. Make sure you have "Klarna" or "Bancontact" enabled in Mollie
  3. Create an order with a GBP currency
  4. Call molliePaymentMethods
  5. Both "Klarna" and "Bancontact" will be returned.
  6. Try to get a payment intent with either of above methods
  7. An error will be thrown that this currency is not supported for the methods

Expected behavior
The molliePaymentMethods should not return unelligible payment methods for the current order's currency (or billing country, for that matter).

It would also be great if extra information (e.g. locale) is passed along, so payment methods can optionally be translated and/or sorted for better UX.

Environment (please complete the following information):

  • @vendure/core version: 2.1.1
  • Nodejs version: 18
  • Database (mysql/postgres etc): postgres
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants