Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code to handle incomplete messages #20

Merged
merged 37 commits into from
Sep 10, 2012
Merged

Add code to handle incomplete messages #20

merged 37 commits into from
Sep 10, 2012

Conversation

cdesjardins
Copy link
Contributor

No description provided.

Adán Sánchez de Pedro Crespo and others added 30 commits June 29, 2012 15:47
if not needed... foreach only runs if there are elements...
Update php/protocol/protocol.class.php
surrounding if when using foreach is redundant
use the "==" operator for comparison
looks better ;) maybe slightly faster
@grssnbchr
Copy link

Hey - I tried this as well and did as you specified. I am also using Android v.2.8.1504 as @ariaveta above, but as you say, that does not seem to matter. I analysed the network traffic in Wireshark and found that, as soon as $w->Message() gets executed and the request sent, I receive a [TCP ACKed Lost Segment] message:
3694 897.894890 173.192.219.156 10.0.2.15 TCP 60 [TCP ACKed lost segment] xmpp-client > 46793 [ACK] Seq=128 Ack=471 Win=65535 Len=0

What happens afterwards, I don't know.. fact is that the message does not get sent. I have made sure that I entered everything correctly.

Does it work for you and what device account do you have? It might really be because your code, the code of venomous0x only works for iPhone?!
Thanks for the help
Winston

@cdesjardins
Copy link
Contributor Author

I have a BB and a few androids and all of those accounts worked with the php setup as an iPhone, they don't care about that. Also if you ran the php/protocol version of the code you should see all the details of what is sent and received in regular text. It seems as if WhatsApp is offline for us for now...

venomous0x pushed a commit that referenced this pull request Sep 10, 2012
Merging @cdesjardins's master, one step toward the next cleaner version. 
Addressing [#17, #20, #34, #26, #40]
@venomous0x venomous0x merged commit 2b6e745 into venomous0x:master Sep 10, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants