Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix priors on kappa for 3p model #15

Closed
venpopov opened this issue Jan 16, 2024 · 0 comments · Fixed by #26
Closed

fix priors on kappa for 3p model #15

venpopov opened this issue Jan 16, 2024 · 0 comments · Fixed by #26
Assignees
@venpopov
Labels
PR - minor Pull-request should update minor version

Comments

@venpopov
Copy link
Owner

The 3p model has a normal(5,0.8) prior on kappa, which is on the log scale, which is too extreme
@venpopov venpopov added the PR - minor Pull-request should update minor version label Jan 16, 2024
@venpopov venpopov self-assigned this Jan 16, 2024
venpopov added a commit that referenced this issue Jan 27, 2024
@venpopov
Change prior on log(kappa) to Normal(2,1). Fixes #15
2d0689e
@venpopov venpopov mentioned this issue Jan 27, 2024
Merged
@venpopov venpopov linked a pull request Jan 27, 2024 that will close this issue
Change prior on log(kappa) to Normal(2,1). Fixes #15 #26
Merged
GidonFrischkorn added a commit that referenced this issue Jan 30, 2024
@GidonFrischkorn
Merge pull request #26 from venpopov/15-fix-priors-on-kappa-for-3p-model
b1ba3a5 
Change prior on log(kappa) to Normal(2,1). Fixes #15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@venpopov venpopov

Labels
PR - minor Pull-request should update minor version
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change prior on log(kappa) to Normal(2,1). Fixes #15 venpopov/bmm
1 participant
@venpopov