Resolve #1594, #1603 #1592
Merged
Resolve #1594, #1603 #1592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InVincible2016
previously approved these changes
May 8, 2020
timothywangdev
changed the title
InVincible2016
suggested changes
May 12, 2020
|
|
||
| class RequestInterceptor { | ||
| intercept = false | ||
| byPassMatchObj = null |
There was a problem hiding this comment.
Add flow type definition
| class RequestInterceptor { | ||
| intercept = false | ||
| byPassMatchObj = null | ||
| stats = {} |
There was a problem hiding this comment.
Add flow type definition
| intercept = false | ||
| byPassMatchObj = null | ||
| stats = {} | ||
| cache = {} |
There was a problem hiding this comment.
Add flow type definition
| @@ -104,7 +104,7 @@ const CRYPTO_ACCOUNTS = [ | |||
| // ledger | |||
| { | |||
| addedAt: 1583802157, | |||
| address: '0xd3ced3b16c8977ed0e345d162d982b899e978588', | |||
| address: '0x6F6a68eC176AAfFE76e6771F2Ea79607f6B79801', | |||
There was a problem hiding this comment.
What's the reason of making this change.
There was a problem hiding this comment.
bypass 0xd3ced3b16c8977ed0e345d162d982b899e978588 for allowance setting for metamask, but we do not want to bypass other types of wallets. This further reduced the number of calls.
| @@ -34,3 +34,6 @@ page | |||
| .on('requestfailed', request => | |||
| console.log(chalk.magenta(`${request.failure().errorText} ${request.url()}`)) | |||
| ) | |||
|
|
|||
| const RequestInterceptor = require('../utils/requestInterceptor').default | |||
| global.requestInterceptor = new RequestInterceptor() | |||
There was a problem hiding this comment.
Add a new line at the end
| }), | ||
| page.goto(`${process.env.E2E_TEST_URL}/contacts`) | ||
| ]) | ||
| //await requestInterceptor.setRequestInterception(true) |
| @@ -7,7 +7,15 @@ const timeout = 180000 | |||
|
|
|||
| describe('Direct transfer form tests', () => { | |||
| beforeAll(async () => { | |||
| /* browser.on('targetcreated', async (target) => { | |||
| ) | ||
| } | ||
|
|
||
| byPass (matchObj) { |
There was a problem hiding this comment.
Add comment to this function
| this.startIntercept() | ||
| } | ||
|
|
||
| incrementStat (key, val) { |
There was a problem hiding this comment.
Add comment to this function
timothywangdev
force-pushed
the
tim
branch
4 times, most recently
from
a845858
to
514a938
Compare
InVincible2016
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.