Skip to content

Commit

Permalink
Merge pull request #1 from tghosth/patch-1
Browse files Browse the repository at this point in the history
Add mitigations to document
  • Loading branch information
artsploit committed Jan 28, 2020
2 parents b2f89e4 + 40e5457 commit c1ac8d5
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
* [[CVE-2017-3163] Arbitrary file read via path traversal attack in ReplicationHandler](#6-cve-2017-3163-arbitrary-file-read-via-path-traversal-attack-in-replicationhandler)
* [[CVE-2019-17558] RCE via Velocity template by @_S00pY](#7-cve-2019-17558-rce-via-velocity-template-by-_s00py)
* [Black box detection](#black-box-detection)
* [Mitigations](#mitigations)
* [Conclusion](#conclusion)

## Introduction
Expand Down Expand Up @@ -433,6 +434,10 @@ GET /xxx?q=aaa%26shards=http://callback_server/solr
GET /xxx?q=aaa&shards=http://callback_server/solr
GET /xxx?q={!type=xmlparser v="<!DOCTYPE a SYSTEM 'http://callback_server/solr'><a></a>"}
```
## Mitigations
The following mitigations can be used to prevent this issue:
* Make sure that user supplied data is url-encoded when included in a manually-crafted request to Solr. (SolrJ does it automatically.) This should prevent injection of additional parameters using the ```&``` character.
* Remove curly brackets (```{``` and ```}``` characters) from user controlled data being passed to Solr to avoid local parameter injection.

## Conclusion
No matter whether the Solr instance is facing the internet, behind the reverse proxy, or used only by internal web applications, allowing to modify Solr search parameters is a significant security risk.
Expand All @@ -445,4 +450,4 @@ In cases where only a web application who uses Solr is accessible, by exploitati
Apache Solr Team - for timely fixing all of these vulnerabilities

### Authors
[Michael Stepankin](https://twitter.com/artsploit), Veracode Research
[Michael Stepankin](https://twitter.com/artsploit), Veracode Research

0 comments on commit c1ac8d5

Please sign in to comment.