Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Nitro build to CI workflow #258

Conversation

dominic-mulligan-arm
Copy link
Member

@dominic-mulligan-arm dominic-mulligan-arm commented Nov 9, 2021

Added a new Nitro CI workflow which builds the nitro and nitro-cli targets for Veracruz. Also expanded existing workflows to also cover their respective *-cli targets.

Due to us hitting disk-space constraints when building for TZ I've also removed some unnecessary pre-installed software from the Github runner:

  • Android support libraries,
  • The .NET runtime,
  • The Glorious Glasgow Haskell Compiler 馃ゲ
  • The Boost C++ library.

This is done now as part of the initial SDK compilation step. Further ideas for maximising disk space, should it be necessary, are available here.

@dominic-mulligan-arm dominic-mulligan-arm added build-process Something related to the Veracruz build process testing Issues related to the Veracruz tests labels Nov 9, 2021
@dominic-mulligan-arm dominic-mulligan-arm changed the title WIP: Added Nitro build to CI workflow Added Nitro build to CI workflow Nov 12, 2021
@dominic-mulligan-arm dominic-mulligan-arm marked this pull request as ready for review November 12, 2021 13:28
@dominic-mulligan-arm
Copy link
Member Author

This is ready for review now: the Nitro workflow is succeeding, at least.

mathias-arm
mathias-arm previously approved these changes Nov 12, 2021
dreemkiller
dreemkiller previously approved these changes Nov 12, 2021
ShaleXIONG
ShaleXIONG previously approved these changes Nov 15, 2021
@dominic-mulligan-arm
Copy link
Member Author

Sorry @mathias-arm and @dreemkiller: it seems that the tz build target is running out of space during the build and aborting (but for some reason Github considers this a success, and will allow the merge). I've extended the changeset to try to free up disk space before every build by removing redundant .Net, Haskell, and Android toolchains/libraries pre-installed on the Azure machines backing Github actions.

@dominic-mulligan-arm
Copy link
Member Author

I'm leaving trustzone-cli build out of this change until I have time to come back and look at why it is consuming so much disk space. I think getting Nitro builds in is more important, for the time being. Can anybody take a look at this and approve/reject as appropriate?

@mathias-arm
Copy link
Contributor

I do wonder if using LTO does not increase the size of the build directories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-process Something related to the Veracruz build process testing Issues related to the Veracruz tests
Projects
No open projects
Technical tasks
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

5 participants