Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hide requestExt #120

Merged
merged 3 commits into from
Sep 13, 2023
Merged

fix: hide requestExt #120

merged 3 commits into from
Sep 13, 2023

Conversation

Zxilly
Copy link
Contributor

@Zxilly Zxilly commented Sep 8, 2023 •
edited

The request instance service_fn received is created by vercel runtime and has nothing in its extensions field. RequestExt will not work as expected.

dglsparsons
dglsparsons previously approved these changes Sep 11, 2023
View reviewed changes
@ecklf
Copy link
Collaborator

ecklf commented Sep 13, 2023

Currently we export this trait so we can access the payload on the request type. I think we could change this to just use RequestPayloadExt?

@Zxilly
Copy link
Contributor Author

Zxilly commented Sep 13, 2023

RequestPayloadExt didn't exist in lambda_http 0.7, we need to bump to a newer version.

@dglsparsons dglsparsons self-requested a review September 13, 2023 09:57
@dglsparsons dglsparsons dismissed their stale review September 13, 2023 09:58

no longer relevant

ecklf
ecklf approved these changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@ecklf ecklf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Cargo.toml Show resolved Hide resolved
@ecklf ecklf merged commit 53d040c into vercel-community:main Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecklf ecklf ecklf approved these changes

@dglsparsons dglsparsons Awaiting requested review from dglsparsons

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zxilly @ecklf @dglsparsons