Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes cart issues #971

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Fixes cart issues #971

merged 1 commit into from
Apr 18, 2023

Conversation

manovotny
Copy link
Collaborator

  1. Updates to latest canary.
  2. Gives a good, solid once over on all cart styles.
  3. Changed SHOPIFY_STORE_DOMAIN environment variable to not include https:// (will document separately on README Update Shopify environment variables to match integration. #967 and Document how to configure the Shopify Admin to use the theme #969).
  4. Fixes layout shift on cart item buttons (hardcoded local code to show both).

CleanShot 2023-04-18 at 10 20 30@2x

  1. Adds links on cart items.

CleanShot 2023-04-18 at 11 56 29

Deleting items in the cart appears to be broke, even before this PR, so we'll address that separately. Thought updating canary might fix it, as it did for a very similar issue last week, but it didn't. Working with the Next.js team on it.

@leerob leerob merged commit e9a26c2 into main Apr 18, 2023
@leerob leerob deleted the fix-cart-item-buttons-layout-shift branch April 18, 2023 17:08
loan-laux pushed a commit to TrellisCommerce/next-commerce-bigcommerce that referenced this pull request May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants