Adds sitemap. #982
Merged
Adds sitemap. #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
manovotny
commented
Apr 21, 2023
| import { MetadataRoute } from 'next'; | ||
|
|
||
| const baseUrl = process.env.NEXT_PUBLIC_VERCEL_URL | ||
| ? `https://${process.env.NEXT_PUBLIC_VERCEL_URL}` |
There was a problem hiding this comment.
Can this be done dynamically like this or should we hardcode it to demo.vercel.store?
There was a problem hiding this comment.
This should work, vs. hardcoding. There isn't a metabaseBase here similar to the built-in SEO support AFAIK, but could be wrong.
leerob
approved these changes
Apr 23, 2023
| ? `https://${process.env.NEXT_PUBLIC_VERCEL_URL}` | ||
| : 'http://localhost:3000'; | ||
|
|
||
| export default async function sitemap(): Promise<Promise<Promise<MetadataRoute.Sitemap>>> { |
| import { MetadataRoute } from 'next'; | ||
|
|
||
| const baseUrl = process.env.NEXT_PUBLIC_VERCEL_URL | ||
| ? `https://${process.env.NEXT_PUBLIC_VERCEL_URL}` |
There was a problem hiding this comment.
This should work, vs. hardcoding. There isn't a metabaseBase here similar to the built-in SEO support AFAIK, but could be wrong.
loan-laux
pushed a commit
to TrellisCommerce/next-commerce-bigcommerce
that referenced
this pull request
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://commerce-shopify-git-sitemap-vercel-solutions-vtest314.vercel.app/sitemap.xml