Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vercel Web Analytics #997

Closed
wants to merge 4 commits into from
Closed

Add Vercel Web Analytics #997

wants to merge 4 commits into from

Conversation

tobiaslins
Copy link
Contributor

@tobiaslins tobiaslins commented Apr 26, 2023

Start capturing custom events for Search Add to cart Checkout

@vercel
Copy link

vercel bot commented Apr 26, 2023

You must have Developer access to commit code to Vercel Solutions on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes.

Learn more: https://vercel.com/docs/concepts/teams/roles-and-permissions#enterprise-team-account-roles

@leerob
Copy link
Member

leerob commented May 10, 2023

Could you address the merge conflicts? Will this work when you clone and deploy or do you need to set something up ahead of time?

@tobiaslins
Copy link
Contributor Author

tobiaslins commented May 10, 2023

@leerob I think @timolins mentioned this on Slack. The only problem is that people will need to enable Web Analytics on the dashboard, else they will see a 404 for the script and a log that tells them that they will need to enable it.

@thomasbritton
Copy link

thomasbritton commented May 10, 2023

Interesting feature add, but I feel the nature of requiring this to be enabled in the Vercel Project Settings etc kind of makes me feel that this shouldn't be added to this particular codebase as it's an out of the box solution.

And if you are on the Hobby plan, you can only have the Web Analytics enabled on 1 project if you have multiple projects.

It almost feels like it should be used as a specific template/example such as 'with-web-analytics', similar to the examples here https://github.com/vercel/next.js/tree/canary/examples

@tobiaslins
Copy link
Contributor Author

@thomasbritton agree!
One thing to add: Web Analytics is free on unlimited projects on Hobby (Speed Insights is only 1 project). There is just the 2500 events/month limit that applies.

@leerob
Copy link
Member

leerob commented May 15, 2023

We have decided to leave this out of the template, but should be able to be easily added if the customer wants to do so 🙏

@leerob leerob closed this May 15, 2023
@manovotny manovotny deleted the add-analytics branch July 25, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants