Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cookies): set options when deleting cookies #890

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nonoakij
Copy link

@nonoakij nonoakij commented May 14, 2024

Fixes vercel/next.js#56632

This PR allows the setting of other attributes such as the secure attribute along with domain and path. This adjustment ensures that cookies prefixed with __Secure- can be appropriately deleted.

The W3C's CookieStore#delete is defined as, "Let r be the result of running delete a cookie with url, options["name"], options["domain"], options["path"], and options["partitioned"]."
This PR enables setting attributes beyond those specified.

If it is necessary to align with the CookieStore#delete standard, I think that the options type should be changed to Pick<ResponseCookie, 'name' | 'domain' | 'path' | 'partitioned'>.

Copy link

changeset-bot bot commented May 14, 2024

⚠️ No Changeset found

Latest commit: 80ad647

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 14, 2024

@nonoakij is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ResponseCookies#delete does not work with __Secure-/__Host- cookie prefixes.
1 participant