Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UA and latest stable version on homepage #165

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Fix UA and latest stable version on homepage #165

merged 1 commit into from
Feb 6, 2020

Conversation

pacocoursey
Copy link
Contributor

  • Removes getInitialProps
  • Removes caching
  • Changes endpoint to be just /latest release, so it's a smaller network request

Fixes that the UA was always Windows (cached) and the version was always undefined (code error, was never being fetched).

@vercel
Copy link

vercel bot commented Feb 6, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/zeit/hyper-site/35hziykmj
✅ Preview: https://hyper-site-git-fix-ua.zeit.now.sh

@pacocoursey pacocoursey marked this pull request as ready for review February 6, 2020 01:03
@pacocoursey
Copy link
Contributor Author

pacocoursey commented Feb 6, 2020

Going to skip review as this is a fairly urgent change.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant