Skip to content

Commit

Permalink
Add info about the rebuild-node-pty script
Browse files Browse the repository at this point in the history
  • Loading branch information
matheuss committed Jan 31, 2017
1 parent 4dca240 commit 28e7e8e
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 14 deletions.
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,7 @@ After that, you'll see the binary in the `./dist` folder!
### node-pty issues

If after building during development you get an alert dialog related to `node-pty` issues,
make sure its build process is working correctly by running `npm rebuild` manually inside
the `app` directory.
make sure its build process is working correctly by running `npm run rebuild-node-pty`.

If you're on macOS, this typically is related to Xcode issues (like not having agreed
to the Terms of Service by running `sudo xcodebuild` after a fresh Xcode installation).
Expand Down
19 changes: 7 additions & 12 deletions app/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -133,10 +133,6 @@ execa@^0.4.0:
path-key "^1.0.0"
strip-eof "^1.0.0"

extend@~1.2.1:
version "1.2.1"
resolved "https://registry.yarnpkg.com/extend/-/extend-1.2.1.tgz#a0f5fd6cfc83a5fe49ef698d60ec8a624dd4576c"

file-uri-to-path@0.0.2:
version "0.0.2"
resolved "https://registry.yarnpkg.com/file-uri-to-path/-/file-uri-to-path-0.0.2.tgz#37cdd1b5b905404b3f05e1b23645be694ff70f82"
Expand Down Expand Up @@ -256,9 +252,9 @@ ms@0.7.2:
version "0.7.2"
resolved "https://registry.yarnpkg.com/ms/-/ms-0.7.2.tgz#ae25cf2512b3885a1d95d7f037868d8431124765"

nan@2.2.1:
version "2.2.1"
resolved "https://registry.yarnpkg.com/nan/-/nan-2.2.1.tgz#d68693f6b34bb41d66bc68b3a4f9defc79d7149b"
nan@2.5.0:
version "2.5.0"
resolved "https://registry.yarnpkg.com/nan/-/nan-2.5.0.tgz#aa8f1e34531d807e9e27755b234b4a6ec0c152a8"

node-fetch@1.6.3:
version "1.6.3"
Expand All @@ -267,12 +263,11 @@ node-fetch@1.6.3:
encoding "^0.1.11"
is-stream "^1.0.1"

node-pty@0.6.0:
version "0.6.0"
resolved "https://registry.yarnpkg.com/node-pty/-/node-pty-0.6.0.tgz#6bb7e58e871b903773595e9ca393c07d077b1ca5"
node-pty@0.6.2:
version "0.6.2"
resolved "https://registry.yarnpkg.com/node-pty/-/node-pty-0.6.2.tgz#d990a447926bbf59b80242c8ae4a85c232040a0c"
dependencies:
extend "~1.2.1"
nan "2.2.1"
nan "2.5.0"

npm-run-path@^1.0.0:
version "1.0.0"
Expand Down

0 comments on commit 28e7e8e

Please sign in to comment.