distinct urlTags vs notes

vercel · Jan 23, 2018 · 43e7fd7 · 43e7fd7
1 parent af527b6
commit 43e7fd7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/app/updater.js b/app/updater.js
@@ -70,7 +70,10 @@ module.exports = win => {
   const {rpc} = win;
 
   const onupdate = (ev, releaseNotes, releaseName, date, updateUrl, onQuitAndInstall) => {
-    const releaseUrl = updateUrl || `https://github.com/zeit/hyper/releases/tag/${releaseName}`;
+    const releaseUrl = {
+      file: updateUrl || undefined,
+      tag: `https://github.com/zeit/hyper/releases/tag/${releaseName}`
+    };
     rpc.emit('update available', {releaseNotes, releaseName, releaseUrl, canInstall: !!onQuitAndInstall});
   };
 

diff --git a/lib/components/notifications.js b/lib/components/notifications.js
@@ -79,7 +79,7 @@ export default class Notifications extends PureComponent {
                 window.require('electron').shell.openExternal(ev.target.href);
                 ev.preventDefault();
               }}
-              href={this.props.updateReleaseUrl}
+              href={this.props.updateReleaseUrl.tag}
             >
               notes
             </a>).{' '}
@@ -106,7 +106,7 @@ export default class Notifications extends PureComponent {
                   window.require('electron').shell.openExternal(ev.target.href);
                   ev.preventDefault();
                 }}
-                href={this.props.updateReleaseUrl}
+                href={this.props.updateReleaseUrl.file}
               >
                 Download
               </a>