-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The popup about canary version is annyoing, can't disable that! #2983
Comments
Agree. I would love to have this stop showing up. |
Hmm, are you sure you don't have |
Here's the lines that fetches and displays the message, can't see anything directly that looks wrong 🤔 needs some investigation https://github.com/zeit/hyper/blob/canary/app/notifications.js#L4-L35 |
@chabou do you know what code is running at https://hyper-news.now.sh ? 🤔 |
@chabou @albinekb { "text": "Version 2.1.0-canary.1 is available. New `lineHeight` option, improvements and bug fixes based on feedback ⚡\r",
"url": "https://github.com/zeit/hyper/releases/tag/2.1.0-canary.1",
"dismissable": true,
"versions": ["< 2.1.0-canary.1"],
"platforms": ["linux"]
} |
Thanks for checking that @szmarczak, looks like there's a bug in https://hyper-news.now.sh 🤔 |
Newsfeed was used as a fallback because Linux version doesn't have an auto-updater. But now, Hyper uses |
Maybe re-deploy a new |
I feel I'm missing something here. Why not add a config option to disable fetching notifications at all? Why request an empty message? |
@MKRhere because you want to disable notification because of this bug. We should fix this bug (notification about a canary update even if you are on the stable channel). |
I see. But this has been a long time bug. I'd actually like to dismiss notifications permanently after once. Hmm. I mean when I open a terminal session, the last thing I want to keep getting is an update notification. |
I think the middle ground here would be a 'Don't Show Again' option for notifications. |
I think that we should reevaluate the need to dismiss (or disable) notification after fixing this shameful and awful bug. |
@chabou The code is at https://github.com/zeit/hyper-news. I'll move the deployment and alias over to the |
@chabou done ✌️ |
Not needed anymore since vercel/hyper#2497 Fixes vercel/hyper#2983 (comment)
Ubuntu 18.04 LTS, Hyper 2.0.0 (Stable), default settings.
It is so annoying, every time Hyper launches I have to click
[x]
which is almost invisible because of the color it has. Please add a setting to disable notifications about canary versions.The text was updated successfully, but these errors were encountered: