Use same hazel endpoint to notify update to Linux users
#2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albinekb
reviewed
Nov 27, 2017
app/updater.js
Outdated
|
|
||
| const {platform} = process; | ||
| const isLinux = true; //platform === 'linux'; |
There was a problem hiding this comment.
indeed...... Sorry for that
albinekb
approved these changes
Nov 27, 2017
chabou
added a commit
to chabou/hyper-news
that referenced
this pull request
May 17, 2018
Not needed anymore since vercel/hyper#2497 Fixes vercel/hyper#2983 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2476
This PR implements a pseudo
auto-updater-linux. It fetches the same URL and trigger same events. All data related to the available release (name, note, date etc...), are passed toupdate-availableevent instead ofupdate-downloaded.Internal updater use Electron autoUpdater or this one on Linux.