-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite code to make xo happy without any rules #730
Comments
I can work on this! |
The changes for this issue are massive in some cases. I'm planning to send one PR for each rule fulfilled. |
@davegomez Cool, thanks! 😘 |
|
Context of why those rules should be enabled: #723 (comment) |
Then I would recommend just disabling it inline where it's used with a ESLint directive: // eslint-disable-line react/no-danger |
So are we gonna add the Proptypes or don't? And I agree with @sindresorhus that we should use the inline comment to disable the |
@leo @sindresorhus How do we want to handle It seems like the only place we are using them is for CSS pseudo-classes (e.g., Should we disable with inline comments? I don't suppose we could switch the xo rule to |
@maxdeviant Done: xojs/eslint-config-xo@abe5ed6 I've been meaning to change it. It sounded good initially, but became annoying after awhile. Will be part of the next XO release being released soon (in a few days to a week). |
@sindresorhus Okay, sounds good :) I'll double check, but once we update XO then we should able able to re-enable the rule and cross |
@leo As per @sindresorhus' comment, |
@maxdeviant Got it! But it looks like he hasn't released it yet... |
@leo My bad, forgot to mention that part 😅 |
We don't use |
The long-term goal is to comply with all of xo's standards, so that we can remove these rules. I already made the code comply to many rules, but these are left.
The text was updated successfully, but these errors were encountered: