No string refs #766
Merged
No string refs #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this the only string ref we have? |
|
@rauchg Surprisingly, yes! It's the only one |
12 tasks
|
@maxdeviant Please resolve the conflicts! 😊 |
|
@leo Resolved 🎉 |
|
Thanks! 😘 |
tylerong
pushed a commit
to tylerong/hyper
that referenced
this pull request
Jul 3, 2017
* Use callback ref instead of string ref * Enable react/no-string-refs rule for xo * Replace additional string refs * Fix broken merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the one instance of a string ref, and re-enables the xo rule to check for them, as per #730.