Comply XO's "jsx-filename-extension" rule

[davegomez]

No description provided.

[davegomez]

Any comment @ekmartin?

[ekmartin]

Yes, sorry - here it is: I'm not sure if I agree with this. Dan Abramov explains it much better than I do though: airbnb/javascript#985 (comment)

[davegomez]

I agree with that too but we are trying to comply with XO's rules #730, is not about what we think or what we like.

[ekmartin]

Of course it is - for such a large project as this there's really not that much virtue in trying to comply with rules that we don't agree with, at least in my opinion. If the rule makes sense, definitely, but if not I don't see the huge win in bending the project in a way that feels unnatural.

I don't think a lot of people will go into developing HyperTerm with an expectation of how everything should look based on them knowing about xo. They'll run the linter, and fix what's being complained about - regardless of whether they agree with it or not. Thus I think some bikeshedding on issues like this is warranted, and not something to be afraid of.

[ekmartin]

We shouldn't disable the rule nonetheless though, if we don't want .jsx we should set it to react/jsx-filename-extension: ["error", { "extensions": [".js"] }]

[davegomez]

I don't fight with linters and I don't see any problem in renaming the files. I agree that use the rule react/jsx-filename-extension: ["error", { "extensions": [".js"] }] could be a solution, but I don't see any gain either way.

[matheuss]

This rule was removed from eslint-config-xo-react 😅

[davegomez]

@matheuss awesome, we should update the ruleset then

[matheuss]

cc @sindresorhus

[ekmartin]

Closing in favor of #741.

[sindresorhus]

I already commented about it here: #723 (comment)