Add documentation for Windows #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
j1n6
commented
Mar 7, 2017
j1n6
commented
- Improve the configuration documentation for Windows setup
- Give real example for bash and PowerShell setup
Give real example for bash and PowerShell setup
|
looks like a build to failure, not related to the commit. How can i trigger a retest without a commit? |
|
anyone to review this? |
| // - Make sure to use a full path if the binary name doesn't work | ||
| // - Remove `--login` in shellArgs | ||
| // | ||
| // Bash on Windows |
There was a problem hiding this comment.
Is this a reference to the new WSL bash shell? That's not too clear here.
There was a problem hiding this comment.
Yes indeed. I will add additional text to clarify.
There was a problem hiding this comment.
and squash the commit..
albinekb
approved these changes
May 13, 2017
|
closed & reopened to trigger tests |
chabou
suggested changes
May 13, 2017
app/config-default.js
Outdated
| // Windows | ||
| // - Make sure to use a full path if the binary name doesn't work | ||
| // - Remove `--login` in shellArgs | ||
| // |
There was a problem hiding this comment.
There's a trailing space here. (See tests)
@activars can you fix it?
chabou
approved these changes
May 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.