Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add category option under linux key in root package.json #2184

Merged
merged 1 commit into from
Sep 7, 2017

Conversation

h93xV2
Copy link
Contributor

@h93xV2 h93xV2 commented Sep 7, 2017

In response to issue entry #2097, a specific category option has been defined under the linux key in the root package.json file. This allows Hyper to take advantage of features that have been added to the most recent version of electron-builder.

Note: I tried to make this commit before, but mistakenly added app/yarn.lock, in addition to the solution of the stated issue, to the branch. Thus, this is a corrected version of my earlier attempt.

In response to issue entry vercel#2097, a specific category option has been defined under the linux key in the root package.json file. This allows Hyper to take advantage of features that have been added to the most recent version of electron-builder.

Note: I tried to make this commit before, but mistakenly added app/yarn.lock, in addition to the solution of the stated issue, to the branch. Thus, this is a corrected version of my earlier attempt.
Copy link
Contributor

@albinekb albinekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you 🎉 Should we add more than one category or is this enough?

@h93xV2
Copy link
Contributor Author

h93xV2 commented Sep 7, 2017

@albinekb I believe this is enough. Hyper fits perfectly in the TerminalEmulator category.

@chabou chabou merged commit 26a9823 into vercel:master Sep 7, 2017
@chabou
Copy link
Collaborator

chabou commented Sep 7, 2017

Thank you so much @h93xV2 !
(FYI: you don't have to make a new PR. Only need to commit in your branch to update a PR)

@h93xV2
Copy link
Contributor Author

h93xV2 commented Sep 7, 2017

@chabou I will remember that in the future, thanks!

@h93xV2 h93xV2 deleted the issue2097fix branch September 7, 2017 19:34
@h93xV2 h93xV2 restored the issue2097fix branch September 7, 2017 19:34
chabou added a commit that referenced this pull request Sep 10, 2017
* master:
  Add default keymaps reference to documentation (#2185)
  Add category option under linux key in root package.json (#2184)
  Add vscode debug config, update readme (#2181)
  Get default config options when not specified in user config (#2126)
  Fix session cleaning (#2176)
  Delete .DS_Store file (#2171)
@h93xV2 h93xV2 deleted the issue2097fix branch September 12, 2017 03:13
spncrgr pushed a commit to spncrgr/hyper that referenced this pull request Sep 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants