Improved context menu #2425
Merged
Improved context menu #2425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leo
added
the
🎨 Type: Enhancement
chabou
previously requested changes
Nov 4, 2017
app/menus/menus/shell.js
Outdated
| } | ||
| }, | ||
| { | ||
| type: 'separator' | ||
| }, | ||
| { | ||
| label: 'Close Session', | ||
| label: 'Close Tab', | ||
| accelerator: commandKeys['pane:close'], | ||
| click(item, focusedWindow) { | ||
| execCommand('pane:close', focusedWindow); |
There was a problem hiding this comment.
You should modify this command if you change its name
|
What do you think to call this item
Its suit well if there is only one session and it closes app directly (on Windows/Linux) and if there is multiple panes in tab and it closes only one pane. |
|
@chabou You're right. Done! |
timothyis
approved these changes
Nov 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the order of a few context menu entries to make more sense.
As an example, "horizontal splitting" has to come before "vertical splitting" because "x" always comes before the "y" axis. In addition, I replaced "Close Session" with "Close Tab" since we're saying "New Tab" and not "New Session" above.