Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance plugin installation #2440

Merged
merged 1 commit into from
Nov 8, 2017
Merged

Enhance plugin installation #2440

merged 1 commit into from
Nov 8, 2017

Conversation

chabou
Copy link
Collaborator

@chabou chabou commented Nov 6, 2017

This PR enhance plugin installation:

  • No more double error notification triggered when plugin is added to config before launching Hyper
  • Error notification message is better when yarn failed:
    • Before : Command failed: /Users/chabou/Documents/Projets/hyper/node_modules/electron/dist/Electron.app/Contents/MacOS/Electron /Users/chabou/Documents/Projets/hyper/bin/yarn-standalone.js install --no-emoji --no-lockfile --cache-folder /Users/chabou/.hyper_plugins/cache error Couldn't find package "lklfdklfkl" on the "npm" registry.
    • After: error Couldn't find package "lklfdklfkl" on the "npm" registry.
  • Delay before launching plugin installation is reduced from 5s to 1s

@Stanzilla
Copy link
Collaborator

Very nice, that was always super confusing to users.

@chabou chabou merged commit 3a3ee01 into vercel:canary Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants