Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorg #386

Merged
merged 9 commits into from
Jul 24, 2016
Merged

Reorg #386

merged 9 commits into from
Jul 24, 2016

Conversation

rauchg
Copy link
Member

@rauchg rauchg commented Jul 24, 2016

In 7 easy(?) steps I moved to electron-builder. Benefits:

  • Outputs multiple platforms easily
  • No more hand-written scripts
  • Good directory conventions
    • Main electron code goes inside ./app. Only ./app is included in the build, which is why we target the webpack build there and we moved index.html inside it.
    • Browser code is now more accessible (inside ./lib/)
  • Way easier time explaining how to get up and running to newcomers ✨

Thanks @sindresorhus for the suggestion

@rauchg rauchg merged commit aaed99a into master Jul 24, 2016
@rauchg rauchg deleted the reorg branch July 24, 2016 17:59
@lordgiotto
Copy link
Contributor

Great :) Unfortunately it revert PR #307.
Please, in package.json, inside build, can you add "extend-info" property that points to Info.plist inside ./static (or inside ./build if you think it's better to move it)?
Otherwise I could do the pull request myself if you prefer :)

Thank you very much!

@develar
Copy link

develar commented Jul 28, 2016

I see that you disabled asar. It is not recommended because windows io is very poor. JFYI: I will fix electron-userland/electron-builder#602 soon and open PR to enable asar.

@Stanzilla Stanzilla mentioned this pull request May 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants