Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified Info.plist generation to enable folder drop onto dock icon #307

Merged
merged 2 commits into from
Jul 20, 2016

Conversation

lordgiotto
Copy link
Contributor

This commit extend the Info.plist generated with the OSX package, adding CFBundleDocumentTypes for folders.

With this hyperterm is allowed to open folders dropped on the dock icon, so modifications like #276 can handle them :)

@kirb
Copy link

kirb commented Jul 20, 2016

👍

@kirb
Copy link

kirb commented Jul 20, 2016

Should this also say it's capable of opening public.executable or does this already implicitly allow all files?

@lordgiotto
Copy link
Contributor Author

lordgiotto commented Jul 20, 2016

It allow only folders for now, since your pull request handle only directory. Why it should be capable to open public.executable?

However, when hyperterm will be able to handle new file types, it will be enough to modify the static/Info.plist file :)

@kirb
Copy link

kirb commented Jul 20, 2016

It supports both. Files are executed; folders are switched to.

@lordgiotto
Copy link
Contributor Author

It supports both. Files are executed; folders are switched to.

Oh, you're right, sorry :)

However I'm facing an issue and I cannot figure out why: it accepts all files, despite Info.plist CFBundleDocumentTypes contains only folders.
I tried CFBundleTypeOSTypes fold, LSItemContentTypes public.directory, and many other combinations: whatever file type I set it accepts all file types dropped on the dock icon; if I don't set any CFBundleDocumentTypes, it doesn't accept any.

Do you have any idea why it's happening?

@lordgiotto
Copy link
Contributor Author

Ok, I tried a lot of different configurations, nothing let me prevent any files to be dropped on the app dock icon. However I've rewritten Info.plist with a more precise file association (folders, app bundles, resolvables and unix-executables). Other files must be handled application side i guess.

@rauchg rauchg merged commit c75d5de into vercel:master Jul 20, 2016
@rauchg
Copy link
Member

rauchg commented Jul 20, 2016

Awesome stuff @lordgiotto

This was referenced Jul 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants