Use local config file in dev. Fix #903 #904
Conversation
| @@ -16,8 +16,8 @@ const notify = require('./notify'); | |||
| const cache = new Config(); | |||
|
|
|||
| // modules path | |||
| const path = resolve(homedir(), '.hyper_plugins'); | |||
| const localPath = resolve(homedir(), '.hyper_plugins', 'local'); | |||
| const path = resolve(config.getConfigDir(), '.hyper_plugins'); | |||
There was a problem hiding this comment.
const path = resolve(config.getConfigDir(), '.hyper_plugins')
const localPath = resolve(path, 'local')?
There was a problem hiding this comment.
no it was like this before, but when you're already at it 😉
| @@ -6,3 +6,8 @@ node_modules | |||
|
|
|||
| # logs | |||
| npm-debug.log | |||
|
|
|||
| # optionnal dev config file and plugins directory | |||
There was a problem hiding this comment.
ty :) it is "optionnel" in french
* master: chore(package): update electron to version 1.4.5 (vercel#949) add onRendererWindow, because it actually available. check ./lib/utils/plugins.js:193 (vercel#924) increase timeout for update checks (vercel#928) Change URL regex - fixes vercel#867 (vercel#943) Make the close menu items less ambiguous Comply to XO's no-warning-comments rule Prefer default export to make XO happy (vercel#931) chore(package): update ms to version 0.7.2 (vercel#933) chore(package): update copy-webpack-plugin to version 4.0.0 (vercel#927) log plugins' errors in Electron console (vercel#923) Improve tabs title (vercel#892) increase notification timeout up to 30m (vercel#913) Create github templates (vercel#919) chore(package): update electron to version 1.4.4 (vercel#907)
* master: (68 commits)
|
Do you plan to merge it ? 😊 |
|
@chabou first this need rebase. |
|
@ppot I made a rebase 8 hours ago and this PR seems up-to-date, no ? |
|
@chabou I can't see when the rebase is done 😂 |
|
Ahah of course but I made a rebase before my comment "Do you plan..." |
|
This will need some upgrades. But okay for a start! |
|
Hou yeah ! Thank you !! |
* Use local config file in dev * Fix typo * Reuse path variable to compose localPath * Fix lint errors
No description provided.