Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: log in/out bodies for requests that have body parsed with json() #35

Merged
merged 1 commit into from Sep 12, 2017
Merged

fix: log in/out bodies for requests that have body parsed with json() #35

merged 1 commit into from Sep 12, 2017

Conversation

tungv
Copy link
Contributor

@tungv tungv commented Sep 10, 2017

json() calls will never be resolved in res.end

close #33

@tungv
fix: log in/out bodies for requests that have body parsed with json()
cfc7ec0 
`json()` calls will never be resolved in `res.end`

close vercel#33
@tungv tungv mentioned this pull request Sep 12, 2017
Merged
timneutkens
timneutkens approved these changes Sep 12, 2017
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay 👍

@timneutkens timneutkens merged commit 4c568ce into vercel:master Sep 12, 2017
@tungv tungv deleted the fix-33 branch September 12, 2017 17:47
@tungv
Copy link
Contributor Author

tungv commented Sep 12, 2017

thanks @timneutkens

@rriegs rriegs mentioned this pull request Jan 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timneutkens timneutkens timneutkens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

POST and PUT do not log response to console
2 participants
@tungv @timneutkens