Check if async is available before loading async-to-gen #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albinekb
approved these changes
Dec 21, 2016
| We now use [async-to-gen](https://github.com/leebyron/async-to-gen), | ||
| so that the only transformation that happens is converting `async` | ||
| and `await` to generators. | ||
| We now use [is-async-supported](https://github.com/timneutkens/is-async-supported) combined with [async-to-gen](https://github.com/leebyron/async-to-gen), |
| @@ -57,7 +58,9 @@ if ('/' !== file[0]) { | |||
| file = resolve(process.cwd(), file) | |||
| } | |||
|
|
|||
| require('async-to-gen/register') | |||
| if(!isAsyncSupported()) { | |||
There was a problem hiding this comment.
Add a space for consistency (looks like there are spaces further down in this file)
if (!isAsyncSupported()) {
rauchg
reviewed
Dec 24, 2016
| We now use [async-to-gen](https://github.com/leebyron/async-to-gen), | ||
| so that the only transformation that happens is converting `async` | ||
| and `await` to generators. | ||
| We now use [is-async-supported](https://github.com/timneutkens/is-async-supported) combined with [async-to-gen](https://github.com/leebyron/async-to-gen), |
There was a problem hiding this comment.
The temporal reference ("now") is only interesting to people who already knew about the implementation details. I'd take it out
|
Great work @timneutkens |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.