Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decrease install size #395

Merged
merged 6 commits into from May 2, 2019
Merged

Decrease install size #395

merged 6 commits into from May 2, 2019

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented May 2, 2019 •
edited

  • Remove below Node 8 check because node 6 is end-of-life
  • Remove chalk as it was only used in --help
  • Upgrade arg as the newer version is about 80% smaller.

@timneutkens timneutkens requested review from leo and styfle May 2, 2019 11:30
styfle
styfle previously approved these changes May 2, 2019
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! 🎉

@timneutkens timneutkens merged commit 7d99648 into vercel:master May 2, 2019
@timneutkens timneutkens deleted the add/smaller-install-size branch May 2, 2019 12:11
@timneutkens timneutkens restored the add/smaller-install-size branch May 2, 2019 12:14
@timneutkens timneutkens mentioned this pull request May 2, 2019
Merged
@timneutkens timneutkens deleted the add/smaller-install-size branch May 2, 2019 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle left review comments

@leo leo Awaiting requested review from leo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timneutkens @styfle