Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --hostname argument to cli #1010

Closed
jessehattabaugh opened this issue Feb 6, 2017 · 7 comments
Closed

Add --hostname argument to cli #1010

jessehattabaugh opened this issue Feb 6, 2017 · 7 comments

Comments

@jessehattabaugh
Copy link
Contributor

In Cloud9 http servers have to be run with the hostname 0.0.0.0. The cli always starts on localhost.

@arunoda
Copy link
Contributor

arunoda commented Feb 6, 2017

You can use our custom server for that.
See: https://github.com/zeit/next.js#custom-server-and-routing

@arunoda arunoda closed this as completed Feb 6, 2017
@jessehattabaugh
Copy link
Contributor Author

I could, but wouldn't it be nice to have an argument like how firebase-tools and other dev servers do? Here's a PR I made, but haven't tested yet because your build process is kinda strange to me. #1017

@arunoda
Copy link
Contributor

arunoda commented Feb 7, 2017

Yeah. That's good too.
I saw your PR. Let's take it.

@arunoda arunoda reopened this Feb 7, 2017
@rauchg
Copy link
Member

rauchg commented Feb 7, 2017

-H too?

@jessehattabaugh
Copy link
Contributor Author

I changed it to -H

@timneutkens
Copy link
Member

Fixed in #1017

@jessehattabaugh
Copy link
Contributor Author

Woo hoo! Thanks y'all!

@lock lock bot locked as resolved and limited conversation to collaborators May 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants