Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

with-reasonml example - `not compatible with next@9 #10388

Closed
vasco3 opened this issue Feb 3, 2020 · 2 comments · Fixed by #10399
Closed

with-reasonml example - `not compatible with next@9 #10388

vasco3 opened this issue Feb 3, 2020 · 2 comments · Fixed by #10399
Labels
good first issue Easy to fix issues, good for newcomers
Milestone
9.2.2

Comments

@vasco3
Copy link
Contributor

vasco3 commented Feb 3, 2020

Examples bug report

Example name

with-reasonml

Describe the bug

A clear and concise description of what the bug is.

Both development and production builds not working on fresh cloned example using next@9.

Nextv9 should use next-transpile-modules v3+ which has a breaking change from v2 (the one in with-reasonml)

To Reproduce

Steps to reproduce the behavior, please provide code snippets or a repository:

  1. Clone with-reasonml example
  2. Install packages (with the latest next-transpile-modules)
  3. Fire dev or prod to see an error

Expected behavior

App should be working as intended (next@7.0.x is working)

System information

  • OS: macOS 10.15.3 Catalina
  • Browser Brave and Chrome
  • Version of Next.js: [e.g. 9.2.1]

Additional context

Add any other context about the problem here.
@timneutkens timneutkens added good first issue Easy to fix issues, good for newcomers help wanted labels Feb 3, 2020
@timneutkens
Copy link
Member

Feel free to open a PR.

vasco3 pushed a commit to vasco3/next.js that referenced this issue Feb 3, 2020
Fix vercel#10388 with-reasonml example
51e2fa0
@vasco3 vasco3 mentioned this issue Feb 3, 2020
Merged
@Timer Timer added this to the 9.2.2 milestone Feb 3, 2020
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Easy to fix issues, good for newcomers
Projects
None yet
Milestone
9.2.2
Development

Successfully merging a pull request may close this issue.

Fix with-reasonml example vasco3/next.js
4 participants
@Timer @vasco3 @timneutkens @balazsorban44