Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement i18n routing RFC #17110

Closed
timneutkens opened this issue Sep 15, 2020 · 1 comment
Closed

Implement i18n routing RFC #17110

timneutkens opened this issue Sep 15, 2020 · 1 comment
Assignees
@ijjk
Milestone
iteration 11

Comments

@timneutkens
Copy link
Member

#17078
@timneutkens timneutkens added this to the iteration 9 milestone Sep 15, 2020
@Timer Timer modified the milestones: iteration 9, iteration 10 Sep 22, 2020
@ijjk ijjk mentioned this issue Sep 26, 2020
Merged
5 tasks
kodiakhq bot pushed a commit that referenced this issue Oct 7, 2020
@ijjk
Add initial changes for i18n support (#17370)
b2d1d87 
This adds the initial changes outlined in the [i18n routing RFC](#17078). This currently treats the locale prefix on routes similar to how the basePath is treated in that the config doesn't require any changes to your pages directory and is automatically stripped/added based on the detected locale that should be used. 

Currently redirecting occurs on the `/` route if a locale is detected regardless of if an optional catch-all route would match the `/` route or not we may want to investigate whether we want to disable this redirection automatically if an `/index.js` file isn't present at root of the pages directory. 

TODO: 

- [x] ensure locale detection/populating works in serverless mode correctly
- [x] add tests for locale handling in different modes, fallback/getStaticProps/getServerSideProps

To be continued in fall-up PRs

- [ ] add tests for revalidate, auto-export, basePath + i18n
- [ ] add mapping of domains with locales
- [ ] investigate detecting locale against non-index routes and populating the locale in a cookie

x-ref: #17110
This was referenced Oct 8, 2020
Merged
Merged
kodiakhq bot pushed a commit that referenced this issue Oct 9, 2020
@ijjk
Update to generate auto static pages with all locales (#17730)
2170dfd 
Follow-up PR to #17370 this adds generating auto-export, non-dynamic SSG, and fallback pages with all locales. Dynamic SSG pages still control which locales the pages are generated with using `getStaticPaths`. To further control which locales non-dynamic SSG pages will be prerendered with a follow-up PR adding handling for 404 behavior from `getStaticProps` will be needed. 

x-ref: #17110
@Timer Timer modified the milestones: iteration 10, iteration 11 Oct 27, 2020
@Timer Timer closed this as completed Oct 30, 2020
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ijjk ijjk

Labels
None yet
Projects
None yet
Milestone
iteration 11
Development

No branches or pull requests
4 participants
@Timer @timneutkens @balazsorban44 @ijjk