New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconsider default deviceSizes
configuration to handle 2x/3x DPI
#18420
Milestone
Comments
Suggested defaults: {
deviceSizes: [640, 750, 828, 1080, 1200, 1920, 2048, 3840],
imageSizes: [16, 32, 48, 64, 96, 128, 256, 384]
} We can also use 1x, 2x, 3x variants for |
styfle
changed the title
Reconsider default
Reconsider default Nov 2, 2020
deviceWidths
configurationdeviceWidths
configuration to handle 2x/3x DPI
styfle
changed the title
Reconsider default
Reconsider default Nov 3, 2020
deviceWidths
configuration to handle 2x/3x DPIdeviceSizes
configuration to handle 2x/3x DPI
that would be awesome |
This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Currently, deviceWidths is
[320, 420, 768, 1024, 1200]
, however we did not consider DPI.For example, an iPhone 5/SE is 320px wide but it requests the a 640px image from the
srcset
because its 2x DPI.However, because we don't have 640w as an option, this means the 768w image is used because it is the next largest.
Apple Docs
The text was updated successfully, but these errors were encountered: