Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default widths configuration to handle 2x/3x DPI #18717

Merged
merged 7 commits into from Nov 3, 2020

Conversation

styfle
Copy link
Member

@styfle styfle commented Nov 3, 2020

  • Update default deviceSizes
  • Add default imageSizes
  • Use layout value to determine which srcset to use

Fixes #18420
Closes #18714

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@styfle styfle requested a review from Timer November 3, 2020 01:49
@ijjk
Copy link
Member

ijjk commented Nov 3, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js img-default-sizes-layouts Change
buildDuration 15s 14.6s -390ms
nodeModulesSize 90 MB 90 MB ⚠️ +771 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js img-default-sizes-layouts Change
/ failed reqs 0 0
/ total time (seconds) 2.878 2.815 -0.06
/ avg req/sec 868.55 888.14 +19.59
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.653 1.729 ⚠️ +0.08
/error-in-render avg req/sec 1512.14 1445.89 ⚠️ -66.25
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js img-default-sizes-layouts Change
677f882d2ed8..981d.js gzip 11.3 kB 11.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-89c13e5..d360.js gzip 7.35 kB 7.35 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 58.3 kB 58.3 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary vercel/next.js img-default-sizes-layouts Change
677f882d2ed8..dule.js gzip 7.03 kB 7.03 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-a53bbe5..dule.js gzip 6.35 kB 6.35 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 53.1 kB 53.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js img-default-sizes-layouts Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js img-default-sizes-layouts Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-a674d88..ccde.js gzip 1.35 kB 1.35 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.75 kB 7.75 kB
Client Pages Modern
vercel/next.js canary vercel/next.js img-default-sizes-layouts Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-a4469f3..dule.js gzip 1.32 kB 1.32 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.41 kB 5.41 kB
Client Build Manifests
vercel/next.js canary vercel/next.js img-default-sizes-layouts Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 330 B 330 B
Overall change 652 B 652 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js img-default-sizes-layouts Change
index.html gzip 1 kB 1 kB
link.html gzip 1.01 kB 1.01 kB
withRouter.html gzip 995 B 995 B
Overall change 3.01 kB 3.01 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary vercel/next.js img-default-sizes-layouts Change
buildDuration 17.2s 16.8s -324ms
nodeModulesSize 90 MB 90 MB ⚠️ +771 B
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js img-default-sizes-layouts Change
677f882d2ed8..981d.js gzip 11.3 kB 11.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-89c13e5..d360.js gzip 7.35 kB 7.35 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 58.3 kB 58.3 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary vercel/next.js img-default-sizes-layouts Change
677f882d2ed8..dule.js gzip 7.03 kB 7.03 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-a53bbe5..dule.js gzip 6.35 kB 6.35 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 53.1 kB 53.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js img-default-sizes-layouts Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js img-default-sizes-layouts Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-a674d88..ccde.js gzip 1.35 kB 1.35 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.75 kB 7.75 kB
Client Pages Modern
vercel/next.js canary vercel/next.js img-default-sizes-layouts Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-a4469f3..dule.js gzip 1.32 kB 1.32 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.41 kB 5.41 kB
Client Build Manifests
vercel/next.js canary vercel/next.js img-default-sizes-layouts Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 330 B 330 B
Overall change 652 B 652 B
Serverless bundles
vercel/next.js canary vercel/next.js img-default-sizes-layouts Change
_error.js 1.07 MB 1.07 MB
404.html 4.73 kB 4.73 kB
hooks.html 3.92 kB 3.92 kB
index.js 1.07 MB 1.07 MB
link.js 1.12 MB 1.12 MB
routerDirect.js 1.11 MB 1.11 MB
withRouter.js 1.11 MB 1.11 MB
Overall change 5.48 MB 5.48 MB
Commit: c15b224

@kodiakhq kodiakhq bot merged commit 2b94b1e into canary Nov 3, 2020
@kodiakhq kodiakhq bot deleted the img-default-sizes-layouts branch November 3, 2020 02:12
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reconsider default deviceSizes configuration to handle 2x/3x DPI
3 participants