Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config webpack filename [hash] error #1948

Closed
jason-ivy opened this issue May 12, 2017 · 4 comments · Fixed by #14279
Closed

config webpack filename [hash] error #1948

jason-ivy opened this issue May 12, 2017 · 4 comments · Fixed by #14279

Comments

@jason-ivy
Copy link

next.config.js

webpack: (config, { dev }) => {
    config.output.publicPath = ''
    config.output.filename = '[name].[hash].js'
    return config
  }

the error mssage:

Using "webpack" config function defined in next.config.js.
(node:11216) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): TypeError: Cannot read property 'source' of undefined

@timneutkens
Copy link
Member

@jason-ivy I don't follow what you want to do. We have cache invalidation built into Next.js 😄 no hashes needed.

@edwardfxiao
Copy link

@timneutkens
i think what he wants to do is to change
image
to
image

image
to
image

and how to achieve this? How to append the hash to those files?

@timneutkens
Copy link
Member

You can't right now. Eventually we'll implement that.

@edwardfxiao
Copy link

Hi, @timneutkens can you give us a hint when this hash thing implemented?

@lock lock bot locked as resolved and limited conversation to collaborators Feb 11, 2020
kodiakhq bot pushed a commit that referenced this issue Jun 20, 2020
Updates the way filenames are generated for browser compilation.
Notably:
- All entry bundles now have hashes in production, this includes pages (previously pages used a buildId in the path)
- The AmpFiles no longer depends on hardcoded bundle names, it uses the buildManifest instead (internals)
- All cases where we match the page name from the chunk/entrypoint name now use the same function `getRouteFromEntrypoint` (internals)
- In development we no longer include the "faked" `buildId` set to `development` for page files, instead we just use the `/_next/static/pages` path (was `/_next/static/development/pages`). This was changed as it caused unneeded complexity and makes generating the bundles easier (internals)
- Updated tons of tests to be more resilient to these changes by relying on the buildManifest instead of hardcoded paths (internals)

Follow up of these PRs:
#13759
#13870
#13937
#14130
#14176
#14268


Fixes #6303
Fixes #12087 
Fixes #1948
Fixes #4368
Fixes #4255
Fixes #2548
rokinsky pushed a commit to rokinsky/next.js that referenced this issue Jul 11, 2020
Updates the way filenames are generated for browser compilation.
Notably:
- All entry bundles now have hashes in production, this includes pages (previously pages used a buildId in the path)
- The AmpFiles no longer depends on hardcoded bundle names, it uses the buildManifest instead (internals)
- All cases where we match the page name from the chunk/entrypoint name now use the same function `getRouteFromEntrypoint` (internals)
- In development we no longer include the "faked" `buildId` set to `development` for page files, instead we just use the `/_next/static/pages` path (was `/_next/static/development/pages`). This was changed as it caused unneeded complexity and makes generating the bundles easier (internals)
- Updated tons of tests to be more resilient to these changes by relying on the buildManifest instead of hardcoded paths (internals)

Follow up of these PRs:
vercel#13759
vercel#13870
vercel#13937
vercel#14130
vercel#14176
vercel#14268


Fixes vercel#6303
Fixes vercel#12087 
Fixes vercel#1948
Fixes vercel#4368
Fixes vercel#4255
Fixes vercel#2548
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants