Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React ref is always null with script tag inside Head component #20850

Closed
ahmedosama5200 opened this issue Jan 7, 2021 · 7 comments
Closed

React ref is always null with script tag inside Head component #20850

ahmedosama5200 opened this issue Jan 7, 2021 · 7 comments
Assignees
@jankaifer
Labels
Metadata Related to Next.js' Metadata API. please verify canary The issue should be verified against next@canary. It will be closed after 30 days of inactivity
Milestone
backlog

Comments

@ahmedosama5200
Copy link

ahmedosama5200 commented Jan 7, 2021 •
edited

What version of Next.js are you using?

10.0.5

What version of Node.js are you using?

14.15.3

What browser are you using?

Chrome

What operating system are you using?

Windows

How are you deploying your application?

next dev

Describe the Bug

When using react ref with script tag inside next js Head component, the ref.current is always null

 const scriptRef = useRef<HTMLScriptElement>(null)
 ....

  <Head>
    <script
      ref={scriptRef}
      src="https://apis.google.com/js/client:platform.js?onload=start"
    />
  </Head>

Expected Behavior

I expect that scriptRef.current will hold a reference to the script element

To Reproduce

  1. Include the previously mentioned code in a next js page
  2. check that scriptRef.current is null and it is indeed
@ahmedosama5200 ahmedosama5200 added the bug Issue was opened via the bug report template. label Jan 7, 2021
@ahmedosama5200
Copy link
Author

As a workaround, I am using document.getElementById in useEffect and it's working just fine.
But I am wondering why refs don't work with script tags

@timneutkens
Copy link
Member

It is expected that refs do not work when rendered in next/head because rendering a tag in next/head is not using React to render into the head. We can probably error / warn better for these cases.

@timneutkens timneutkens added kind: story and removed bug Issue was opened via the bug report template. labels Jan 11, 2021
@timneutkens timneutkens added this to the backlog milestone Jan 11, 2021
@Timer Timer modified the milestone: backlog Jan 11, 2021
@ahmedosama5200
Copy link
Author

I also noticed that onLoaded and onError attributes are not working with scripts. Why is that ?

@timneutkens
Copy link
Member

Same reason: #20850 (comment)

@timneutkens timneutkens added the Metadata Related to Next.js' Metadata API. label Nov 17, 2021
@jankaifer jankaifer self-assigned this Dec 1, 2022
@jankaifer jankaifer added the please verify canary The issue should be verified against next@canary. It will be closed after 30 days of inactivity label Dec 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

Please verify that your issue can be recreated with next@canary.

Why was this issue marked with the please verify canary label?

We noticed the provided reproduction was using an older version of Next.js, instead of canary.

The canary version of Next.js ships daily and includes all features and fixes that have not been released to the stable version yet. You can think of canary as a public beta. Some issues may already be fixed in the canary version, so please verify that your issue reproduces by running npm install next@canary and test it in your project, using your reproduction steps.

If the issue does not reproduce with the canary version, then it has already been fixed and this issue can be closed.

How can I quickly verify if my issue has been fixed in canary?

The safest way is to install next@canary in your project and test it, but you can also search through closed Next.js issues for duplicates or check the Next.js releases.

My issue has been open for a long time, why do I need to verify canary now?

Next.js does not backport bug fixes to older versions of Next.js. Instead, we are trying to introduce only a minimal amount of breaking changes between major releases.

What happens if I don't verify against the canary version of Next.js?

An issue with the please verify canary that receives no meaningful activity (e.g. new comments that acknowledge verification against canary) will be automatically closed and locked after 30 days.

If your issue has not been resolved in that time and it has been closed/locked, please open a new issue, with the required reproduction, using next@canary.

I did not open this issue, but it is relevant to me, what can I do to help?

Anyone experiencing the same issue is welcome to provide a minimal reproduction following the above steps. Furthermore, you can upvote the issue using the 👍 reaction on the topmost comment (please do not comment "I have the same issue" without repro steps). Then, we can sort issues by votes to prioritize.

I think my reproduction is good enough, why aren't you looking into it quicker?

We look into every Next.js issue and constantly monitor open issues for new comments.

However, sometimes we might miss one or two due to the popularity/high traffic of the repository. We apologize, and kindly ask you to refrain from tagging core maintainers, as that will usually not result in increased priority.

Upvoting issues to show your interest will help us prioritize and address them as quickly as possible. That said, every issue is important to us, and if an issue gets closed by accident, we encourage you to open a new one linking to the old issue and we will look into it.

Useful Resources

@balazsorban44
Copy link
Member

This issue has been automatically closed because it wasn't verified against next@canary. If you think it was closed by accident, please leave a comment. If you are running into a similar issue, please open a new issue with a reproduction. Thank you.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jankaifer jankaifer

Labels
Metadata Related to Next.js' Metadata API. please verify canary The issue should be verified against next@canary. It will be closed after 30 days of inactivity
Projects
None yet
Milestone
backlog
Development

No branches or pull requests
5 participants
@Timer @timneutkens @jankaifer @balazsorban44 @ahmedosama5200