Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with React 16 #2239

Closed
blackxored opened this issue Jun 12, 2017 · 9 comments
Closed

Doesn't work with React 16 #2239

blackxored opened this issue Jun 12, 2017 · 9 comments

Comments

@blackxored
Copy link

Running on latest master, manually specified react and react-dom ^16.0.x, I get the following error:

ERROR  Failed to compile with 1 errors                                                                                                                                   10:24:43 PM

This module was not found:

* react-dom/lib/ReactReconciler in ./~/next/dist/client/next-dev.js

To install it, you can run: npm install --save react-dom/lib/ReactReconciler
> Ready on http://localhost:3000
@arunoda
Copy link
Contributor

arunoda commented Jun 12, 2017

We haven't tested yet with React 16 and we'll do it when they have a public beta or a RC.

@arunoda arunoda closed this as completed Jun 12, 2017
@msand
Copy link

msand commented Jul 15, 2017

Latest alphas of React 16 now support error boundaries: facebook/react#2461 (comment)

Meanwhile, if you don't care about the error handling and want to test Fiber, you can just comment out

https://github.com/zeit/next.js/blob/62a624775333f8abb4ecdd6896267f2a9b07b25e/client/next-dev.js#L2

and

https://github.com/zeit/next.js/blob/62a624775333f8abb4ecdd6896267f2a9b07b25e/client/next-dev.js#L40-L51

@msand
Copy link

msand commented Jul 15, 2017

Alternatively you can try the fork https://github.com/msand/next.js/tree/fiber from my pull request #2570

@avindra
Copy link

avindra commented Jul 27, 2017

Beta 2 is out, and next is throwing an error about the Reconciler when trying to use React 16

EDIT: Looks like this is already being discussed on #1098

@icflorescu
Copy link

I believe this issue should not be marked as closed, now that React 16.0.0 is out.

@kulshekhar
Copy link

@icflorescu this is being tracked in #2997

@fitfab
Copy link

fitfab commented Sep 27, 2017

React is out: https://facebook.github.io/react/blog/

@timneutkens
Copy link
Member

@fitfab you can see @kulshekhar said we're tracking it in #2997 😄

@lock
Copy link

lock bot commented May 10, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants