swcMinify breaks CountUp package #30414
Milestone
Comments
ch3rn1k
changed the title
timneutkens
added
area: SWC Minify
and removed
bug
This was referenced Nov 2, 2021
Merged
kodiakhq bot
pushed a commit
that referenced
this issue
Nov 2, 2021
## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint` This PR applies - swc-project/swc#2610 This increases the pass limit (which is required to prevent hanging) from 30 to 100. Fixes #30636. - swc-project/swc#2625 This marks assignment with operators as `usage`+ `assign`. Previously it was only `assisgn`. This is to preserve assignments to variables used like `(a += '').split('.'))`. Fixes #30414. --- I expect this to fix some more issues on next.js repository, but I didn't list them because it's not tested.
|
This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
natew
pushed a commit
to natew/next.js
that referenced
this issue
Feb 16, 2022
## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint` This PR applies - swc-project/swc#2610 This increases the pass limit (which is required to prevent hanging) from 30 to 100. Fixes vercel#30636. - swc-project/swc#2625 This marks assignment with operators as `usage`+ `assign`. Previously it was only `assisgn`. This is to preserve assignments to variables used like `(a += '').split('.'))`. Fixes vercel#30414. --- I expect this to fix some more issues on next.js repository, but I didn't list them because it's not tested.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What version of Next.js are you using?
12.0.1
What version of Node.js are you using?
14.17.0
What browser are you using?
Chrome
What operating system are you using?
macOS
How are you deploying your application?
next start
Describe the Bug
When compiling with
swcMinify: trueit breaks CountUp react component and each number became as undefinedExpected Behavior
Working react component, without this feature works fine, but I want to use it
To Reproduce
The text was updated successfully, but these errors were encountered: